Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Redesign README #237

Merged
merged 4 commits into from
Jul 11, 2022
Merged

docs: Redesign README #237

merged 4 commits into from
Jul 11, 2022

Conversation

KnorpelSenf
Copy link
Member

@KnorpelSenf KnorpelSenf commented Jul 11, 2022

Feels like it's time for that again. No large changes, but less clutter and more fixes for some missing information.

Check out the proposed new README here: https://github.com/grammyjs/grammY/blob/redesign-readme/README.md

@KnorpelSenf KnorpelSenf added the documentation Improvements or additions to documentation label Jul 11, 2022
@KnorpelSenf KnorpelSenf changed the title Redesign README docs: Redesign README Jul 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #237 (d465274) into main (6abf4f2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #237   +/-   ##
=======================================
  Coverage   22.21%   22.21%           
=======================================
  Files           9        9           
  Lines        2813     2813           
  Branches       90       90           
=======================================
  Hits          625      625           
  Misses       2187     2187           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6abf4f2...d465274. Read the comment docs.

@KnorpelSenf
Copy link
Member Author

I am fine with this. @Loskir can I merge?

@KnorpelSenf KnorpelSenf requested a review from roj1512 July 11, 2022 19:22
@Loskir
Copy link
Contributor

Loskir commented Jul 11, 2022

Yup

Copy link
Member

@roj1512 roj1512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KnorpelSenf KnorpelSenf merged commit ae9b411 into main Jul 11, 2022
@KnorpelSenf KnorpelSenf deleted the redesign-readme branch July 11, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants