Fix fastify webhook updates when secretToken given #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fastify will normalize all headers to lower case form, so we always get `undefined` by using `req.headers[SECRET_HEADER]`. This PR fixes that by using `toLowerCase` to transform the given header key. Not sure If CloudFlare or AWS Lambda will do that too, so they are leaved unmodified.
Codecov Report
@@ Coverage Diff @@
## main #235 +/- ##
=======================================
Coverage 22.21% 22.21%
=======================================
Files 9 9
Lines 2813 2813
Branches 90 90
=======================================
Hits 625 625
Misses 2187 2187
Partials 1 1 Continue to review full report at Codecov.
|
|
@all-contributors add @oott123 for bug and code |
|
I've put up a pull request to add @oott123! 🎉 |
|
@oott123 your changes are now shipped in the patch version v1.9.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fastify will normalize all headers to lower case form, so we always get
undefinedby usingreq.headers[SECRET_HEADER].This PR fixes that by using
toLowerCaseto transform the given header key.Not sure If CloudFlare or AWS Lambda will do that too, so they are leaved unmodified.