Add support for secret header validation #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #230 +/- ##
=======================================
Coverage 22.21% 22.21%
=======================================
Files 9 9
Lines 2813 2813
Branches 90 90
=======================================
Hits 625 625
Misses 2187 2187
Partials 1 1 Continue to review full report at Codecov.
|
Loskir
reviewed
Jun 21, 2022
Loskir
reviewed
Jun 21, 2022
rojvv
reviewed
Jun 21, 2022
| end: () => callback(null, { statusCode: 200 }), | ||
| respond: (json: string) => callback(null, { statusCode: 200, body: json }), | ||
| unauthorized: () => callback(null, { statusCode: 401 }), |
There was a problem hiding this comment.
There was a problem hiding this comment.
Alright, let's leave this unresolved until then.
|
I have tested this with a bot and it works, but we are going to perform a follow-up PQ by @kraftwerk28 which will align the different frameworks. I suggest to merge and release as soon as #230 (comment) is sorted out. |
Loskir
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check out the new https://core.telegram.org/bots/api#setwebhook