Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove npm scripts not required for GitHub installs #225

Merged
merged 1 commit into from
May 29, 2022
Merged

Conversation

KnorpelSenf
Copy link
Member

Regarding #224 (comment). Is this what you meant?

@KnorpelSenf KnorpelSenf requested review from Satont and rojvv May 29, 2022 11:07
@KnorpelSenf KnorpelSenf changed the title Remove npm scripts which are not required for GitHub installs chore: remove npm scripts which are not required for GitHub installs May 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #225 (092b9c5) into main (bbbc4b5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #225   +/-   ##
=======================================
  Coverage   22.29%   22.29%           
=======================================
  Files           9        9           
  Lines        2794     2794           
  Branches       90       90           
=======================================
  Hits          623      623           
  Misses       2170     2170           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbbc4b5...092b9c5. Read the comment docs.

@Satont
Copy link
Member

Satont commented May 29, 2022

Regarding #224 (comment). Is this what you meant?

Yes.

@KnorpelSenf
Copy link
Member Author

Regarding #224 (comment). Is this what you meant?

Yes.

Alright, will merge after approval.

Copy link
Member

@Satont Satont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rojvv
Copy link
Member

rojvv commented May 29, 2022

@KnorpelSenf Yes, this was what I meant.

@KnorpelSenf
Copy link
Member Author

Thanks!

@KnorpelSenf KnorpelSenf changed the title chore: remove npm scripts which are not required for GitHub installs chore: remove npm scripts not required for GitHub installs May 29, 2022
@KnorpelSenf KnorpelSenf merged commit 6273ca9 into main May 29, 2022
@KnorpelSenf KnorpelSenf deleted the no-npm branch May 29, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants