Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): release & commitlint workflows #219

Merged
merged 8 commits into from
May 25, 2022
Merged

feat(ci): release & commitlint workflows #219

merged 8 commits into from
May 25, 2022

Conversation

rojvv
Copy link
Member

@rojvv rojvv commented May 25, 2022

  • Initialized commitlint workflow to enforce the Conventional Commits style for commit messages.
  • Initialized release workflow to creat releases with automatically-generated release notes on tag creations.
  • Updated the versions for actions/checkout.

@rojvv rojvv requested a review from KnorpelSenf May 25, 2022 14:37
@KnorpelSenf
Copy link
Member

Running it on push is fine. IMO a major advantage of this is that we can generate release notes automatically and add GitHub releases whenever a new tag is created on main. Is it possible to add this?

@rojvv
Copy link
Member Author

rojvv commented May 25, 2022

Yes, it is.

@rojvv
Copy link
Member Author

rojvv commented May 25, 2022

But wait.

@KnorpelSenf
Copy link
Member

With what?

@KnorpelSenf KnorpelSenf marked this pull request as draft May 25, 2022 14:41
@rojvv
Copy link
Member Author

rojvv commented May 25, 2022

It will run 2 times for a pull request coming from the same repository (this repository). Should we do it on push only for main?

@KnorpelSenf
Copy link
Member

KnorpelSenf commented May 25, 2022

How about using the same as

on:
push:
branches: [main]
pull_request:
branches: [main]
?

@rojvv rojvv marked this pull request as ready for review May 25, 2022 14:46
@KnorpelSenf
Copy link
Member

automatically and add GitHub releases whenever a new tag is created on main

Do you want to do this here, too?

@rojvv
Copy link
Member Author

rojvv commented May 25, 2022

Should I?

@KnorpelSenf
Copy link
Member

I think that would make sense, yes. For me, that's the main point of the formats. Readability may also get better, but I must admit that this isn't typically an issue.

@rojvv
Copy link
Member Author

rojvv commented May 25, 2022

Thanks for the article you wrote on your opinions. I thought that I might think of doing both of them here, and I came up with the consequence that I should.

@rojvv rojvv changed the title feat(ci): add commitlint workflow feat(ci): release & commitlint workflows May 25, 2022
.github/workflows/release.yml Outdated Show resolved Hide resolved
@rojvv rojvv requested a review from KnorpelSenf May 25, 2022 15:28
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's hope this works 😄

@KnorpelSenf KnorpelSenf merged commit 97dfed4 into main May 25, 2022
@KnorpelSenf KnorpelSenf deleted the workflows branch May 25, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants