-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement filtering by chat type #203
Conversation
This is blocked by #100. The narrowed context for chat types should be exposed. Will wait in order to prevent merge conflicts. |
Types should ideally also reflect that channel posts are sent in channels, and messages aren't. There may be a lot more dependencies between these things. This will get a very complex type annotation, but it is probably worth it. |
In fact, this should rather be done in Can be merged as-is after an approval. |
Thanks for the review and the suggestion about optional types! I'll merge this as soon as we have a second approval :) @all-contributors add @kolay-v for review |
I've put up a pull request to add @kolay-v! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this as it both simplifies some code and provides better typings. Worked in the bots I tried it both without changes and with using the new chatType
method.
Co-authored-by: EdJoPaTo <[email protected]>
Thanks for the reviews! |
TODO:
Closes #105.