Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify match type evaluation only #169

Merged
merged 6 commits into from
May 4, 2022
Merged

Modify match type evaluation only #169

merged 6 commits into from
May 4, 2022

Conversation

KnightNiwrem
Copy link
Contributor

No description provided.

@KnorpelSenf
Copy link
Member

What was the purpose of this again?

@KnightNiwrem KnightNiwrem marked this pull request as ready for review May 1, 2022 10:27
@KnorpelSenf KnorpelSenf added this to In progress in Coding May 1, 2022
Coding automation moved this from In progress to Review in progress May 1, 2022
KnorpelSenf
KnorpelSenf requested changes May 1, 2022
View reviewed changes
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one idea how this could be simplified, can you confirm that it works?

src/composer.ts Outdated Show resolved Hide resolved
KnorpelSenf
KnorpelSenf requested changes May 4, 2022
View reviewed changes
src/context.ts Outdated Show resolved Hide resolved
Coding automation moved this from Review in progress to Reviewer approved May 4, 2022
KnorpelSenf
KnorpelSenf approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@KnorpelSenf KnorpelSenf merged commit 6ecb1fe into main May 4, 2022
Coding automation moved this from Reviewer approved to Done May 4, 2022
@KnorpelSenf KnorpelSenf deleted the modify-match-type branch May 4, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnorpelSenf KnorpelSenf KnorpelSenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Coding
Archived in project
Coding
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KnightNiwrem @KnorpelSenf