Do not send undefined values in form data #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdJoPaTo
reviewed
Dec 28, 2021
| @@ -113,6 +113,7 @@ async function* payloadToMultipartItr( | |||
| const separator = enc.encode(`\r\n--${boundary}\r\n`); | |||
| let first = true; | |||
| for (const [key, value] of Object.entries(payload)) { | |||
| if (value == null) continue; | |||
There was a problem hiding this comment.
Without trying this out… parse_mode: undefined shouldnt match null?
Maybe I overlooked something but is this working recursive into objects?
There was a problem hiding this comment.
parse_mode: undefinedshouldnt matchnull?
< undefined === null
> false
< undefined == null
> true
Welcome to JS.
Maybe I overlooked something but is this working recursive into objects?
Line 117 in 446a024
Line 30 in 446a024
null values by undefined, which will be removed during serialisation.
There was a problem hiding this comment.
Welcome to JS.
Readable code is fun :D
There was a problem hiding this comment.
It's consistent with the rest of the ecosystem. It's also less verbose than value === undefined || value === null but I do see that point that it could be more readable to use the long version.
EdJoPaTo
approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #144