Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip typechecks while bundling old versions #140

Merged
merged 1 commit into from
Dec 19, 2021

Conversation

KnorpelSenf
Copy link
Member

@KnorpelSenf KnorpelSenf commented Dec 19, 2021

When Deno (and thus TS) upgrades, this can make already released versions stop compiling. That just happened with TS 4.5. Such a case breaks our bundling script. This PR applies --no-check to all bundling operations, and it does so with the following reasons:

  • All versions typecheck when released. This is enough safety.
  • Bundles do not contain types, and since tsc transpilation JS output is stable over versions due to regression tests, we can safely ignore the types in the code.
  • It takes a lot of time to check the same stuff over and over again, which slows down CI by a large factor.
  • Bundling is broken and there are no other solutions that take this little effort and work that well.

@KnorpelSenf
Copy link
Member Author

Taking https://t.me/grammyjs/30528 as an approval.

@KnorpelSenf KnorpelSenf merged commit 024fbdd into main Dec 19, 2021
@KnorpelSenf KnorpelSenf deleted the no-check-during-bundling branch December 19, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant