Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add bot.chosenInlineResult #215

Closed
Tracked by #202
askador opened this issue May 19, 2022 · 11 comments · Fixed by #293
Closed
Tracked by #202

feat: Add bot.chosenInlineResult #215

askador opened this issue May 19, 2022 · 11 comments · Fixed by #293
Assignees
Labels
good first issue Good for newcomers
Projects

Comments

@askador
Copy link

askador commented May 19, 2022

this registers middleware for chosen_inline_result that will be executed for a certain result_id(s)

bot.chosenInlineResult('resultId', async ctx => {...})
@KnorpelSenf KnorpelSenf added this to To do in Coding May 19, 2022
@KnorpelSenf KnorpelSenf added the good first issue Good for newcomers label May 25, 2022
@tusharwebd
Copy link

Hi! I would like to work on this request. This is going to be the first open-source issue I'll work on. Please let me know if you can assign this task to me. Thanks!

@KnorpelSenf
Copy link
Member

Hi! I would like to work on this request. This is going to be the first open-source issue I'll work on. Please let me know if you can assign this task to me. Thanks!

Great to hear, looking forward to your contribution!

@KnorpelSenf
Copy link
Member

Feel free to ask any questions if you get stuck or need help, either here on GitHub or in https://t.me/grammyjs :)

@KnorpelSenf
Copy link
Member

@tusharwebd did you find any time to look into this yet?

@tusharwebd
Copy link

@tusharwebd did you find any time to look into this yet?

Hi! Sorry for the delay. I've started working on this and will have an update on this by Monday?!

@KnorpelSenf
Copy link
Member

KnorpelSenf commented Jul 21, 2022

No worries, there's no hurry. This change is supposed to land in 1.11 but we have the 1.10 release before that anyway, so please take your time. I was just curious if you were still interested in working on this, so thanks for responding :)

@KnorpelSenf
Copy link
Member

The new update changed a lot about the internals that are relevant for this. Let me know if you have any questions about how to work on this :)

@tusharwebd tusharwebd removed their assignment Aug 24, 2022
@KnorpelSenf
Copy link
Member

@tusharwebd I assume you no longer feel like working on this, how is that? :(

@MrVSiK
Copy link
Contributor

MrVSiK commented Oct 5, 2022

Hi! Is anyone working on this feature?

@KnorpelSenf
Copy link
Member

It does not seem like that. @MrVSiK it would be great if you can take over, are you interested in this?

@MrVSiK
Copy link
Contributor

MrVSiK commented Oct 6, 2022

Yes, I'd like to give it a shot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
No open projects
Coding
To do
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants