integration of resources plugin into s2ui #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good but this implementation makes the plugin dependent on the resources plugin, which some users might not have/want, especially if they're not using 2.0 yet. |
|
I've done since a Grails 2.0-SNAPSHOT app with s2ui did not load jquery.js and therefore the ui is usable. Migrating s2ui seems the most easy way to go. Maybe we integrate that in a feature branch of s2ui for later-on merge into master when resources plugin is commonly used? |
|
sorry for the close/reopen, being too dumb to use buttons ;-) |
* Plugin builds with Grails 2.0.0 * moved dependencies to BuildConfig * adding dependency to resources plugin * updating plugin deps to latest version
|
Thanks - I've released version 0.2 of the plugin which correctly works with resources. It includes a lot of code from this pull request but I wanted it to work even if you don't have resources installed, so I didn't apply the pull request. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added defintion of resources compliant to the grails resources plugin into s2ui. Applied defined resources into the layout template. Basic stuff seems ok, but did not test each and every feature.
NB: inclusion of /include/ajaxLogin.gsp result in an exception, so commented that out.