Unnecessary logic double-checks whether user has roles, creates extra ma... #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… map object, loses order. Changed to use a single LinkedHashMap to preserve order, simplified logic to only do the 'contains' check one time for each role.
|
Thanks for your contribution @jstell ! Nice refactoring :) Would you have time to resolve conflicts and provide a test? |
|
Haha! That pull request is over 5 years old! I'm not sure I remember what I was doing that long ago. |
|
No problem @jstell . I completely understand. |
ddelponte
added a commit
that referenced
this pull request
Oct 4, 2017
Applied refactoring from PR #13
sdelamo
pushed a commit
that referenced
this pull request
Oct 19, 2017
Applied refactoring from PR #13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...p object, loses order. Changed to use a single LinkedHashMap to preserve order, simplified logic to only do the 'contains' check one time for each role.