Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple encodings break the password #12

Closed
wants to merge 1 commit into from

Conversation

mgkimsal
Copy link

an encode() method call in it - the password gets encode()d·
twice, and one can never log in with one's password.

Maybe this should stay in these files, and the encode()ing in the·
User domain should be removed. These files have 'salt'
mechanisms in them, which is missing from the user domain,
although that could be added there perhaps?

In any event, I have to modify these files to get basic
self registration and subseqent password authentication to work.

an encode() method call in it - the password gets encode()d·
twice, and one can never log in with one's password.

Maybe this should stay in these files, and the encode()ing in the·
User domain should be removed.  These files have 'salt'
mechanisms in them, which is missing from the user domain,
although that could be added there perhaps?

In any event, I have to modify these files to get basic
self registration and subseqent password authentication to work.
@burtbeckwith
Copy link
Contributor

There's a configuration attribute for this as of version 0.2 - see "Password Encryption" in http:https://grails-plugins.github.com/grails-spring-security-ui/docs/manual/guide/10%20Customization.html

@mgkimsal
Copy link
Author

I don't think that's what I'm getting at.

The generated User/Person domain class will do an encode() in the save method(), but the service and controller provided also encode() as well. It doesn't matter what encoding method is used, it's the fact that a password is being double encoded which is the problem.

Sorry... I misread - I get it, and can deal with this, but... it feels like there should be some standardization going forward, either generated domains should encode, or the controllers/services (by default) should encode. Shipping both by default 'on' causes this to not work out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants