Issue with masked errors is withTransaction() #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at is thrown from a catch block.
|
Looks good, thanks for the PR, I'll release this shortly. |
tednaleid
added a commit
that referenced
this pull request
Mar 18, 2015
Issue with masked errors is withTransaction()
|
just published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A call to
Transaction.exec()triggers the client send and then setsisInMultiandisInWatchto false. If there is a subsequent exception thrown, it is masked because the call toTransaction.discard()throws an exception when the client is no longer in multi.Moving the call to
Transaction.exec()out of the try/catch will allow its own failures to bubble up, but still catch any exceptions thrown by the user's closure.