Ease mocking of redisService #46
Conversation
This change intends to make it easier to override the default wiring by the redis service. Primarily this will be useful for testing. The RedisService is now in src, but is wired manually in RedisGrailsPlugin. Some of the wiring methods that were in RedisGrailsPlugin have been moved to RedisConfigurationUtil so they can be more easily accessed by apps using the plugin.
| } | ||
| } | ||
|
|
||
| "redisService${key}"(serviceClass) { |
There was a problem hiding this comment.
Check for key was removed so that redisService can be wired
sjurgemeyer
changed the title
| import redis.clients.jedis.JedisPoolConfig | ||
| import redis.clients.jedis.JedisSentinelPool | ||
| import redis.clients.jedis.Protocol | ||
| import grails.plugin.redis.test.TestRedisService |
There was a problem hiding this comment.
I think this is a dead import, it's causing the code to not compile for me locally.
There was a problem hiding this comment.
Ugh, sorry about that. Fixed now.
|
Thanks Shaun. I'm having trouble getting the tests to run cleanly (failing on some hamcrest stuff), but they're also failing on I won't have time till tonight to dig into it further, but I'll get this released (or let you know if I have questions) then. |
|
It was my issue with the tests. I upgraded to 2.4.4 and everything worked out. Just merged this in and released it as 1.6.0. Thanks for the pull request! |
|
Thanks Ted! |
This change intends to make it easier to override the default wiring by
the redis service. Primarily this will be useful for testing.
The RedisService is now in src, but is wired manually in
RedisGrailsPlugin. Some of the wiring methods that were in
RedisGrailsPlugin have been moved to RedisConfigurationUtil so they can
be more easily accessed by apps using the plugin.