Memoize Annotations Added #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iables scoped into the closure
…iables scoped into the closure
… a few more tests to write to exercise expire with list and hash. also still need to add hashfield, set and score.
…he redisService if is missing.
… detection and auto injection of the redisService if is missing
…ludes. Using non-exported versions of spock, coverage, narc and BTD.
|
I missed application.properties change, closing pull and re-requesting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the memoize annotation AST transforms as well as cleaned up a bit of code based on codenarc.
The tests for the AST transforms are currently located in the sub project in the test/project/detault directory as I didn't want to pollute the base project with any service or domain objects and was having an issue getting the AST to compile correctly before running the tests inline. Having the tests in the sub project works great for a two phase compile allowing the AST to be performed on the included project. May address that in the future.
Moved to version 1.2, update as appropriate to which ever version you would like. Feel free to add additional and more complex test cases where appropriate.