Invalidate pooled Jedis objects on JedisConnectionException in RedisService #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 looks great! Thanks for the pull request, I think I've been bitten by this issue in the past. |
tednaleid
added a commit
that referenced
this pull request
Jul 7, 2012
Invalidate pooled Jedis objects on JedisConnectionException in RedisService
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Jedis object throws a JedisConnectionException, it becomes invalid, and further attempts to use it may fail or behave strangely. This patch intercepts those exceptions in RedisService.withRedis(), so that invalid Jedis objects aren't returned to the pool to be reused. That solves the problem for RedisService and all its users, but I haven't read the whole plugin and similar issues may arise if Jedis objects are used directly elsewhere.