Support for redis database parameter

[johnrengelman]

This pull request adds support fo the redis database parameter that was added in Jedis 2.1. This allows an application to specify the grails.redis.database value which passes the value to the JedisPool bean. Updates made:

1. Update to Jedis 2.1 which provides the database argument in the JedisPool constructor (gets passed to JedisFactory
2. Modify the doWithSpring closure to get the database property from grails.redis.database or use the default as defined in the Protocol.DEFAULT_DATABASE
3. Modify the declaration for redisPool to pass the database parameter value

Additionally, I found that when I tried to install redis:1.3 into a Grails 1.3.8 application, I would receive a compiler error. This is due to the annotation classes using a syntax that is only supported by Groovy 1.8 or higher, i.e. MemoizeList.groovy
@interface MemoizeList { Class value() default {true}: ...
The definition of value() is not support in Groovy 1.7.8.

[tednaleid]

I haven't tested this yet, but I think that "i" that got stuck on the end of password is a typo. Can you fix that, test it and let me know if it works? Otherwise I don't have a problem with the changes you've made.

[johnrengelman]

Ha. Yeah. Stupid vi. I'll fix that and update the pull request.

John

On May 17, 2012, at 7:43 PM, Ted Naleid
[email protected]
wrote:

•    "redisPool${key}"(JedisPool, ref(poolBean), host, port, timeout, password) { bean ->
  

•    "redisPool${key}"(JedisPool, ref(poolBean), host, port, timeout, passwordi, database) { bean ->
  

I haven't tested this yet, but I think that "i" that got stuck on the end of password is a typo. Can you fix that, test it and let me know if it works? Otherwise I don't have a problem with the changes you've made.

---

Reply to this email directly or view it on GitHub:
https://github.com/grails-plugins/grails-redis/pull/12/files#r843094

[johnrengelman]

Fixed the typo. Ran the tests in the in the plugin and they passed.

[tednaleid]

Thanks for the pull request, I've merged it into master and plan on releasing a new version tonight.