Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple connections #10

Merged
merged 3 commits into from
Apr 28, 2012
Merged

Conversation

ctoestreich
Copy link
Contributor

@tednaleid Here are the changes we discussed. I updated the plugin wiring code to create services with camel case names. I also left in the withConnection method as a helper method on the redisService. I went back and forth on just removing it, but I do like the explicitness of the intention when using it. In the end the result is the same as using bean by name, so probably no harm.

I squashed my changes (or attempted to) into this branch. Let me know if everything looks okay as I am still a rookie at squash-branching.

edit: I missed removing the resources.groovy file and didn't want to go through the squash again. :)

-C

@tednaleid tednaleid merged commit 27cde1d into grails:master Apr 28, 2012
@tednaleid
Copy link
Contributor

This is perfect @ctoestreich thanks for all your work on it. I also appreciate that you're really good about both testing and documenting your pull requests.

The squash you did looked great as well to remove the first iteration of stuff from history to keep things clean. I made a couple of extra notes in the readme about multiple connections, but otherwise left your work completely untouched. Release will go out tonight if I can get the new grails release process figured out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants