Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tednaleid Here are the changes we discussed. I updated the plugin wiring code to create services with camel case names. I also left in the withConnection method as a helper method on the redisService. I went back and forth on just removing it, but I do like the explicitness of the intention when using it. In the end the result is the same as using bean by name, so probably no harm.
I squashed my changes (or attempted to) into this branch. Let me know if everything looks okay as I am still a rookie at squash-branching.
edit: I missed removing the resources.groovy file and didn't want to go through the squash again. :)
-C