Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getTotalCount() tests for sorting parameters (7.3.x backport) #1760

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Add getTotalCount() tests for sorting parameters (7.3.x backport) #1760

merged 2 commits into from
Oct 6, 2023

Commits on Oct 5, 2023

  1. Add getTotalCount() test on empty result for list() method 

    This is for consistency with the test for the criteria.
    @darxriggs
    darxriggs committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    c8036da View commit details
    Browse the repository at this point in the history

  2. Add getTotalCount() tests for sorting parameters 

    This is to check that a getTotalCount() implementation should not
have sorting in the generated query. Otherwise, depending on the
database and its strictness configuration, the query might fail.
    @darxriggs
    darxriggs committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    12183b7 View commit details
    Browse the repository at this point in the history