Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make project compatible with Groovy 3.0.19 #1754

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

matrei
Copy link
Contributor

@matrei matrei commented Sep 18, 2023

No description provided.

@puneetbehl
Copy link
Contributor

I appreciate your contribution, but I'm concerned that releasing a version of Grails Data Mapping with an update to Apache Groovy 3.0.19 might introduce compatibility issues with other projects that haven't been updated to the same version yet. This includes Grails Core, Grails GSP, Grails Views, Grails Testing Support, GORM Hibernate5, GORM MongoDB, and GORM Neo4J.

@matrei
Copy link
Contributor Author

matrei commented Sep 25, 2023

Well, if I downgrade to Groovy v3.0.11 again in this branch (in gradle.properties) and run the test suit, all the tests passes.
It should be compatible with earlier versions of Groovy, it's just that later versions of Groovy are more strict.
Is it an option to change back to v3.0.11 and keep the other changes, for easier upgrading later?

@puneetbehl
Copy link
Contributor

puneetbehl commented Sep 26, 2023

I believe that would be the best path moving forward. I will try to plan to update to Apache Groovy 3.0.19 in Grails 6.1.0. However, I am also planning to start work to support Apache Groovy 4 with GORM 9.

@puneetbehl puneetbehl merged commit 3f7b3cc into grails:8.0.x Nov 5, 2023
3 checks passed
@matrei matrei deleted the matrei/groovy-3.0.19-compatible branch November 5, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants