Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1445 apply generated annotation #1507

Merged

Conversation

aulea
Copy link
Contributor

@aulea aulea commented Aug 3, 2021

Solution for #1445
Mark grails-GORM Traits methods as Generated and also with AST transformation added methods/constructors, so Jacoco could ignore them in its coverage reports.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Alar Aule seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@demus-nine
Copy link

demus-nine commented Nov 29, 2021

When is this going to be merged? It's been waiting since april, so now someone needs to give it some care.
It's a blocker for anyone trying to use jacoco (because it's the only one that can handle compilestatic code) and gorm for coverage. Cobertura and openclover seem to have been abandoned.

@danieldemus
Copy link

Anyone? Without this you can't do meaningful coverage with grails, which in many cases is a requirement automatically disqualifying the framework from consideration.

@puneetbehl puneetbehl merged commit ed6d474 into grails:7.0.x Feb 1, 2022
@boardbloke
Copy link

boardbloke commented Jun 1, 2022

Hi @puneetbehl ,

Is there any chance of getting this changed merged into the branch of grails-data-mapping being used by the latest grails? It looks like its been committed to the 7.0.x branch but not pulled into 7.2.x or above - lack of @generated is causing all our coverage reports to look horrible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants