#1368 - respect FactoryBean.getObjectType contract, use context… #1371
Conversation
… classloader where appropriate - DatastoreServiceMethodInvokingFactoryBean.getObjectType returns null if not initialized (i.e. arguments is null, getArguments() returns Object[]). that allows AbstractAutowireCapableBeanFactory to initialize DatastoreServiceMethodInvokingFactoryBean if necessary - AbstractDatastoreInitializer and SoftServiceLoader use the context classloader to load data service classes. this way, autowiring data services by type works reliably with spring boot devtools restart (RestartClassLoader)
|
fyi: being curious, i tried to revert e8ef560 on top of this commit - and the sample app still starts sucessfully injecting the interface-typed data service with devtools restart enabled. |
| @@ -22,7 +22,10 @@ class DatastoreServiceMethodInvokingFactoryBean extends MethodInvokingFactoryBea | |||
|
|
|||
| @Override | |||
| Class<?> getObjectType() { | |||
| arguments[0] as Class<?> | |||
| if (arguments) { | |||
There was a problem hiding this comment.
I think the check should be if (arguments != null && arguments.size() == 1 ). Also, instead of returning null maybe we should call super.getObjectType().
|
Also, it would be great if you could send a PR to include the failing scenario in the sample application. https://github.com/grails/gorm-hibernate5/tree/7.0.x/examples/test-data-service |
unfortunately i found no way to enable devtools restart for one or all integration tests (ref. https://github.com/spring-projects/spring-boot/blob/v2.1.15.RELEASE/spring-boot-project/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/restart/DefaultRestartInitializer.java) - any ideas? and i think adding devtools and a |
|
Right, now that you mentinoed it I realized that I also failed to achieve the same earlier. However, I was thinking of testing that you are able to inject the Data Service into BeanPostProcessor (the sample application you shared). |
|
sure thats np! pr asap. |
…classloader where appropriate
DatastoreServiceMethodInvokingFactoryBean.getObjectTypereturns null if not initialized (i.e.argumentsisnull,getArguments()returnsObject[]). that allowsAbstractAutowireCapableBeanFactoryto initializeDatastoreServiceMethodInvokingFactoryBeanif necessaryAbstractDatastoreInitializerandSoftServiceLoaderuse the context classloader to load data service classes. this way, autowiring data services by type works reliably with spring boot devtools restart (RestartClassLoader)@puneetbehl primarily for review by you.
after i fixed
DatastoreServiceMethodInvokingFactoryBean.getObjectTypelocally and ran the sample app, i still got aNoSuchBeanDefinitionExceptionalthough i could see the bean definition..after some fun debugging in, i saw that it was again classloader-related: 2 different instances of
interface DummyDataServicebeing compared byDefaultListableBeanFactory.findAutowireCandidates/ClassUtils.isAssignable: one byAppClassLoader, the other one byRestartClassLoader.do you have a suggestion how to properly unit/integration test this? i saw grails/gorm-hibernate5/examples/test-data-service but the tests do not use the restart classloader anyway, right?
thanks for taking a look.