DirtyChecking fails for fields defined in belongsTo

[snimavat]

I noticed that many of our domain classes doesnt update the record in database and no update query is being fired by hibernate.

Looking in the decompiled code revealed that some of the fields are not marked with DirtyCheckedProperty and the dirty checking code is not weaved into setter.

I noticed that most of the time, the issue is with those associations which are in beoingsTo

So i created following test in grails-data-mapping project DirtyCheckTransformationSpec which fails.

@Entity
class Parent {
    String name
}

@Entity
class Child {
    String name
    static belongsTo = [parent:Parent]
}


 void "Test dirty check with belongsTo"() {
        when:
        Child child = new Child()
        child.trackChanges()

        then:
        !child.hasChanged()
        !child.hasChanged("parent")

        when:
        child.name = "test"

        then:
        child.hasChanged()
        child.hasChanged("name")

        when:
        child.parent = new Parent()

        then:
        child.hasChanged()
        child.hasChanged("name")
        child.hasChanged("parent")
    }

the assertion fails on line child.hasChanged("parent")

Gorm version 6.1.x, Grails 3.3.2

[snimavat]

Looks like the issue is, the setters/field for associations defined in belongsTo doesnt exist when DirtyCheckingTransformer runs.

final propertyNodes = classNode.getProperties()

above does not return property nodes for those associations defined in belongsTo

[graemerocher]

Most probably because the other class was already compiled

[snimavat]

@graemerocher both classses are in same project. What could be the solution here.

[snimavat]

@graemerocher Do you think this is a valid issue, can there be any fix.. or any temporary workaround.

[graemerocher]

Seems like a valid issue, but I'm not sure what can me done about it. This would normally occur only if one class is compiled after the other instead of both classes being compiled together

[snimavat]

Ok, i see... In our project, both of the domains are in same project, nothing special about the domains, or build, almost a regular grails project. And still, when i see at decompiled code, i see, a considerable amount of domains has this exact issue.

[graemerocher]

Provide an example that reproduces the issue can we can take a look

[snimavat]

@graemerocher the test above is not good enough ?

[snimavat]

@graemerocher Verified and seem to be working good in 6.1.11.BUILD-SNAPSHOT thanks