a first implementation draft for grails/gorm-hibernate5#63 #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
review/feedback would be appreciated. some things to note:
HibernateConnectionSource
orAbstractHibernateDatastore
in the implementation intentionallygrails-data-mapping-hibernate-core
and I am not sure whats the current state there reg. compatibility with hibernate 3/4 vs. hibernate-5.2-only.Metadata
(instead of usingHibernateDatastore
)?Metadata
from theMetadataIntegrator
to the place where it is exposed, instead of relying on a hibernate service registry lookup?HibernateDatastore.getMetadataInternal()
remainprivate
or better be declaredprotected
?i welcome any corrections/suggestions/improvements.
thank you!