Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a first implementation draft for grails/gorm-hibernate5#63 #64

Merged
merged 2 commits into from
Nov 16, 2017

Conversation

zyro23
Copy link
Contributor

@zyro23 zyro23 commented Nov 15, 2017

review/feedback would be appreciated. some things to note:

  • this branch originates from the 6.1.x branch and this pr also targets 6.1.x. that is because i was not able to build/publish the grails-data-mapping master locally. not sure if there is wip going on?
    • if i should rebase onto master (this can be considered an enhancement/feature) and pr to master please say so and i will further investigate whats going on with master
  • i did not involve HibernateConnectionSource or AbstractHibernateDatastore in the implementation intentionally
    • those reside in grails-data-mapping-hibernate-core and I am not sure whats the current state there reg. compatibility with hibernate 3/4 vs. hibernate-5.2-only.
  • maybe there is a better way to expose the Metadata (instead of using HibernateDatastore)?
  • maybe there is a better way to pass the Metadata from the MetadataIntegrator to the place where it is exposed, instead of relying on a hibernate service registry lookup?
  • if the current implementation is considered "ok", should HibernateDatastore.getMetadataInternal() remain private or better be declared protected?

i welcome any corrections/suggestions/improvements.

thank you!

@graemerocher
Copy link
Member

Looks ok to me.. don't see a reason why it should be changed from private

@zyro23
Copy link
Contributor Author

zyro23 commented Nov 16, 2017

cool, thanks. i will update the pull-request so that the hibernate5 grails plugin uses the exposed metadata for schemaExport and then i hope this is ready to merge.

@graemerocher graemerocher merged commit 2ee968e into grails:6.1.x Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants