Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to allow user collection types. #46

Closed
wants to merge 1 commit into from
Closed

Fix to allow user collection types. #46

wants to merge 1 commit into from

Conversation

bkoehm
Copy link
Contributor

@bkoehm bkoehm commented Jul 21, 2017

i.e., a UserCollectionType, not just a UserType implementation, can now be specified for the "type" in the mapping.

…ust a

UserType implementation, can now be specified for the "type" in the mapping.
@CLAassistant
Copy link

CLAassistant commented Jul 21, 2017

CLA assistant check
All committers have signed the CLA.

}
value = new SimpleValue(mappings, table);
bindSimpleValue(currentGrailsProp, null, (SimpleValue) value, EMPTY_PATH, mappings, sessionFactoryBeanName);
}
else if (currentGrailsProp.getType().isEnum()) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not immediately obvious, all I have done is switch the "if" and "else if" here so that the collectionType check comes first and the userType check comes second. Necessary because both userType and collectionType are not null when using a UserCollectionType as the "type" in the mapping.

@bkoehm
Copy link
Contributor Author

bkoehm commented Jul 24, 2017

Another pull forthcoming.

@bkoehm bkoehm closed this Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants