This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Add terminationGracePeriodSeconds helm value #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
approved these changes
Jul 11, 2023
|
If you increment the version number it should auto release the chart: |
Closed
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jul 18, 2023
* Add terminationGracePeriodSeconds helm value * Render manifests * Bump chart version * Update chart README
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been reported multiple times that the unfinished block is lost at shutdown. One of the most common reasons in case of k8s deployment is the fact that ingesters may not be able to flush all the data before being terminated forcibly due to expiration of
terminationGracePeriodSeconds(defaults to 30s).The change makes the parameter configurable: now it is set to 10m by default for ingesters when deployed as micro services.
Related #688