Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updates note for helm bug workaround #9899

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

tacole02
Copy link
Contributor

@tacole02 tacole02 commented Nov 13, 2024

What this PR does

This PR updates the note at https://grafana.com/docs/helm-charts/mimir-distributed/latest/run-production-environment-with-helm/#deploy-on-openshift to provide additional insight into the Helm chart bug and possible workarounds.

Which issue(s) this PR fixes or relates to

Fixes https://github.com/grafana/mimir-squad/issues/2521

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@tacole02 tacole02 added the type/docs Improvements or additions to documentation label Nov 13, 2024
@tacole02 tacole02 self-assigned this Nov 13, 2024
@tacole02 tacole02 requested a review from a team as a code owner November 13, 2024 23:39
@tacole02 tacole02 requested a review from narqo November 13, 2024 23:41
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you! I didn't realize the helm bug was fixed. Should we mention which versions of helm are affected (or which version fixes the bug)?

@tacole02
Copy link
Contributor Author

That's a great idea, @dimitarvdimitrov ! I added the version for the Helm fix. Thank you!

@tacole02
Copy link
Contributor Author

btw @dimitarvdimitrov , if it still looks good, would you mind merging this PR for me? I don't have merge rights in mimir.

@dimitarvdimitrov dimitarvdimitrov merged commit 5f48810 into main Nov 14, 2024
29 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the docs/mimir-squad-2521 branch November 14, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants