Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block-builder-scheduler: Check per-partition errors #9886

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

seizethedave
Copy link
Contributor

@seizethedave seizethedave commented Nov 12, 2024

What this PR does

Fix a spot where we weren't checking all available errors that come out of kadmin/kgo API calls.

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@seizethedave seizethedave marked this pull request as ready for review November 12, 2024 17:44
@seizethedave seizethedave requested a review from a team as a code owner November 12, 2024 17:44
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@seizethedave seizethedave merged commit 78db6a8 into main Nov 13, 2024
29 checks passed
@seizethedave seizethedave deleted the davidgrant/bb-err-check branch November 13, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants