[Jsonnet] Fix memberlist when using a stateful ruler

[Whyeasy]

Signed-off-by: Whyeasy [email protected]

What this PR does / why we need it:

When using stateful rulers and the memberlist as its ring, generating the resources with jsonnet throws in an error regarding the ruler_deployment. The ruler_statefulset didn't receive the meberlist labels either.

Checklist

• Documentation added
• Tests updated
• Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
• Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

[grafanabot]

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

[Whyeasy]

It looks like there went something wrong with the jsonnet bundler in the pipeline and not the code contribution. Is this correct?

[grafanabot]

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

[chaudum]

lgtm, maybe another 👀 from @cstyan ?

[stale]

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

• Mark issues as revivable if we think it's a valid issue but isn't something we are likely
  to prioritize in the future (the issue will still remain closed).
• Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

[Whyeasy]

Still would like to have this fix in 😄 but waiting on another look at it by @cstyan

[grafanabot]

./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

[cstyan]

@Whyeasy Can you show me the error you get? We're only using statefulsets internally and don't get a jsonnet error about the deployments. But you are right, the label for the statefulset was missing. Nothing would have broken, the label is only used for joining the ring and we have all pods that use memberlist join the same ring, but still worth fixing.

[Whyeasy]

@cstyan, I get the following error:

Error: got an error while extracting env `environments/dev`: recursion did not resolve in a valid Kubernetes object. In path `.ruler_deployment.spec.template.metadata.labels` found key `loki_gossip_member` of type `string` instead.

During reproducing the error I noticed the following change also fixed my issue:

ruler_deployment+: if !$._config.memberlist_ring_enabled || !$._config.ruler_enabled || $._config.stateful_rulers then {} else gossipLabel,

But I guess it's better to stay consistent here and at the ruler_statefulset as well 😄

[cstyan]

Sorry, I missed your reply. I'll check this out more this week.

[cstyan]

I'm not able to reproduce the error you get in our environments that only have stateful rulers deployed, but I don't see any issue with merging this since it's just checking the stateful ruler config value for both the deployment and statefulset.