Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define a simple CI pipeline #66

Merged
merged 1 commit into from
Jun 22, 2023
Merged

feat: define a simple CI pipeline #66

merged 1 commit into from
Jun 22, 2023

Conversation

K-Phoen
Copy link
Member

@K-Phoen K-Phoen commented Jun 19, 2023

Introduces a CI workflow to run make test for PRs.

@K-Phoen K-Phoen marked this pull request as ready for review June 19, 2023 22:01
@K-Phoen K-Phoen requested a review from Duologic June 19, 2023 22:01
@Duologic
Copy link
Member

Duologic commented Jun 22, 2023

Currently the test make target is set up to install (part of) grafonnet from Github rather than the local branch, which doesn't always deliver reliable results for the changes one makes. Taking that into account, this CI job is already an improvement as it does test changes in grafonnet-base.

@Duologic Duologic merged commit a835b1b into main Jun 22, 2023
1 check passed
@Duologic Duologic deleted the ci-pipeline branch June 22, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants