Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudwatch: Add monitoring badge for metric insights #89956

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Conversation

idastambuk
Copy link
Contributor

What is this feature?

Adds a monitoring badge as part of https://github.com/grafana/oss-plugin-partnerships/issues/886, under metricInsightsCrossAccountEnabled feature toggle.

Why do we need this feature?

part of https://github.com/grafana/oss-plugin-partnerships/issues/886

Which issue(s) does this PR fix?:

Fixes https://github.com/grafana/oss-plugin-partnerships/issues/971

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@idastambuk idastambuk requested a review from a team as a code owner July 2, 2024 14:58
@idastambuk idastambuk requested review from sarahzinger and kevinwcyu and removed request for a team July 2, 2024 14:58
@github-actions github-actions bot added this to the 11.2.x milestone Jul 2, 2024
@sarahzinger
Copy link
Member

I think we don't need to add this to changelog tho, maybe we can do that when its ready for testing

@idastambuk idastambuk changed the title Add monitoring badge for metric insights Cloudwatch: Add monitoring badge for metric insights Jul 4, 2024
@idastambuk idastambuk added the no-changelog Skip including change in changelog/release notes label Jul 4, 2024
@idastambuk idastambuk merged commit 4fc42b8 into main Jul 4, 2024
15 checks passed
@idastambuk idastambuk deleted the monitoring-badge branch July 4, 2024 09:22
@aangelisc aangelisc modified the milestones: 11.2.x, 11.2.0 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend datasource/CloudWatch no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants