Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Move SCSS mixins to be where they're used #89907

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

ashharrison90
Copy link
Contributor

What is this feature?

  • consolidates SCSS mixins to be located where they're used
    • removes a few unused mixins
    • all the remaining mixins are only used in one place
    • move them to be where they're used for easier cleanup later

Why do we need this feature?

  • clean up old deprecated SCSS 🧹

Who is this feature for?

  • grafana devs

Which issue(s) does this PR fix?:

For #64129

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ashharrison90 ashharrison90 added type/chore no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Jul 1, 2024
@ashharrison90 ashharrison90 added this to the 11.2.x milestone Jul 1, 2024
@ashharrison90 ashharrison90 self-assigned this Jul 1, 2024
@ashharrison90 ashharrison90 requested a review from a team as a code owner July 1, 2024 10:25
@ashharrison90 ashharrison90 requested review from joshhunt and Clarity-89 and removed request for a team July 1, 2024 10:25
@ashharrison90 ashharrison90 merged commit ba64ee4 into main Jul 2, 2024
24 checks passed
@ashharrison90 ashharrison90 deleted the ash/scss-cleanup-12 branch July 2, 2024 10:28
@ashharrison90 ashharrison90 restored the ash/scss-cleanup-12 branch August 8, 2024 09:41
@aangelisc aangelisc modified the milestones: 11.2.x, 11.2.0 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/chore
Projects
Status: 🚀 Done
Development

Successfully merging this pull request may close these issues.

3 participants