Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gops: Update texts in main irm page #89810

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Gops: Update texts in main irm page #89810

merged 2 commits into from
Jul 1, 2024

Conversation

soniaAguilarPeiron
Copy link
Member

@soniaAguilarPeiron soniaAguilarPeiron commented Jun 27, 2024 •
edited
Loading

What is this feature?

This PR updates some texts on the cards in the IRM main page (configuration tracker).
Conversation in slack for the context 👀

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@soniaAguilarPeiron soniaAguilarPeiron added area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes good cross gops-fe Share with a GOps Frontend dev on another focus labels Jun 27, 2024
@soniaAguilarPeiron soniaAguilarPeiron added this to the 11.2.x milestone Jun 27, 2024
@soniaAguilarPeiron soniaAguilarPeiron self-assigned this Jun 27, 2024
@soniaAguilarPeiron soniaAguilarPeiron requested a review from a team as a code owner June 27, 2024 06:46
@soniaAguilarPeiron soniaAguilarPeiron requested review from gillesdemey, obetomuniz, tomratcliffe and konrad147 and removed request for a team June 27, 2024 06:46
soniaAguilarPeiron
soniaAguilarPeiron commented Jun 27, 2024
View reviewed changes
public/app/features/gops/configuration-tracker/irmHooks.ts
@@ -340,7 +340,7 @@ export const useGetConfigurationForUI = ({
function getConnectDataSourceConfiguration() {
const description = dataSourceCompatibleWithAlerting
? 'You have connected a datasource.'
: 'Connect at least one data source to start receiving data.';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this dot for consistency

@soniaAguilarPeiron soniaAguilarPeiron force-pushed the irm/configuration-tracker-update-texts branch from de7ae6c to cf6c3d5 Compare June 27, 2024 07:09
alyssawada
alyssawada approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@alyssawada alyssawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soniaAguilarPeiron soniaAguilarPeiron merged commit 86466ae into main Jul 1, 2024
14 checks passed
@soniaAguilarPeiron soniaAguilarPeiron deleted the irm/configuration-tracker-update-texts branch July 1, 2024 15:00
@aangelisc aangelisc modified the milestones: 11.2.x, 11.2.0 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomratcliffe tomratcliffe tomratcliffe approved these changes

@alyssawada alyssawada alyssawada approved these changes

@gillesdemey gillesdemey Awaiting requested review from gillesdemey gillesdemey is a code owner automatically assigned from grafana/alerting-frontend

Assignees

@soniaAguilarPeiron soniaAguilarPeiron

Labels
area/frontend good cross gops-fe Share with a GOps Frontend dev on another focus no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Milestone
11.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@soniaAguilarPeiron @tomratcliffe @alyssawada @aangelisc