Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSSQL: Password auth for Azure AD #89746

Merged
merged 20 commits into from
Jul 16, 2024
Merged

MSSQL: Password auth for Azure AD #89746

merged 20 commits into from
Jul 16, 2024

Conversation

bossinc
Copy link
Contributor

@bossinc bossinc commented Jun 25, 2024 •
edited
Loading

Add Azure password auth for MSSQL. Add an Azure flag for client_password_credentials_enabled because we do not recommend using this.

@bossinc bossinc changed the title Password auth for Azure AD MSSQL: Password auth for Azure AD Jun 25, 2024
@bossinc bossinc linked an issue Jul 1, 2024 that may be closed by this pull request
MSSQL: Add AAD type authentication=ActiveDirectoryPassword #77090
Closed
@bossinc bossinc mentioned this pull request Jul 3, 2024
Merged
aangelisc
aangelisc reviewed Jul 10, 2024
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work on this - just a couple nits in the comments to be addressed. I'd also suggest updating the tests in AzureAuth.test.ts to account for the new auth method 😊

public/app/plugins/datasource/mssql/azureauth/AzureCredentialsForm.tsx Outdated Show resolved Hide resolved
conf/defaults.ini Outdated Show resolved Hide resolved
conf/sample.ini Outdated Show resolved Hide resolved
docs/sources/setup-grafana/configure-grafana/_index.md Outdated Show resolved Hide resolved
pkg/tsdb/mssql/mssql.go Outdated Show resolved Hide resolved
public/app/plugins/datasource/mssql/azureauth/AzureCredentialsForm.tsx Outdated Show resolved Hide resolved
@bossinc bossinc marked this pull request as ready for review July 15, 2024 14:07
@bossinc bossinc requested review from torkelo and a team as code owners July 15, 2024 14:07
@bossinc bossinc requested review from a team and chri2547 as code owners July 15, 2024 14:07
@github-actions github-actions bot added this to the 11.2.x milestone Jul 15, 2024
aangelisc
aangelisc approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @bossinc, tested and everything works as expected 🥳

@bossinc bossinc merged commit 319a874 into main Jul 16, 2024
29 checks passed
@bossinc bossinc deleted the andrew/mssql-ad-password-auth branch July 16, 2024 19:08
leonorfmartins pushed a commit that referenced this pull request Jul 17, 2024
@bossinc @aangelisc @leonorfmartins
MSSQL: Password auth for Azure AD (#89746)
0727d54 
* Password auth for Azure AD

* rename auth fields

* add azure flag for client password cred enabled

* prettier

* rename flag

* Update go.mod

* Update public/app/plugins/datasource/mssql/azureauth/AzureCredentialsForm.tsx

Co-authored-by: Andreas Christou <[email protected]>

* Apply suggestions from code review

Co-authored-by: Andreas Christou <[email protected]>

* update package

* go mod

* prettier

* remove password

* gowork

* remove unused env test

* linter

---------

Co-authored-by: Andreas Christou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aangelisc aangelisc aangelisc approved these changes

@torkelo torkelo Awaiting requested review from torkelo torkelo is a code owner

@chri2547 chri2547 Awaiting requested review from chri2547 chri2547 is a code owner

@asimpson asimpson Awaiting requested review from asimpson asimpson is a code owner automatically assigned from grafana/partner-datasources

@adamyeats adamyeats Awaiting requested review from adamyeats adamyeats is a code owner automatically assigned from grafana/partner-datasources

@alyssabull alyssabull Awaiting requested review from alyssabull alyssabull is a code owner automatically assigned from grafana/partner-datasources

@Clarity-89 Clarity-89 Awaiting requested review from Clarity-89 Clarity-89 is a code owner automatically assigned from grafana/grafana-frontend-platform

@JoaoSilvaGrafana JoaoSilvaGrafana Awaiting requested review from JoaoSilvaGrafana JoaoSilvaGrafana is a code owner automatically assigned from grafana/grafana-frontend-platform

@academo academo Awaiting requested review from academo academo is a code owner automatically assigned from grafana/plugins-platform-frontend

@wbrowne wbrowne Awaiting requested review from wbrowne wbrowne is a code owner automatically assigned from grafana/plugins-platform-backend

@andresmgot andresmgot Awaiting requested review from andresmgot andresmgot is a code owner automatically assigned from grafana/plugins-platform-backend

@oshirohugo oshirohugo Awaiting requested review from oshirohugo oshirohugo is a code owner automatically assigned from grafana/plugins-platform-backend

Assignees
No one assigned
Labels
add to changelog area/backend area/frontend datasource/MSSQL Microsoft SQL Server Data Source type/docs
Projects
None yet
Milestone
11.2.x
Development

Successfully merging this pull request may close these issues.

MSSQL: Add AAD type authentication=ActiveDirectoryPassword
2 participants
@bossinc @aangelisc