Introduce Comparator interface #88016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonorfmartins
added
the
no-changelog
ryantxu
reviewed
May 17, 2024
diegommm
approved these changes
May 20, 2024
|
LGTM, some tests are failing though. |
|
LGTM as well. Was there any discussion about what we might want to return? For instance, returning some kind of struct which provides a full accounting of which fields were a match and which ones were not? |
leonorfmartins
force-pushed
the
dualwriter/comparator
branch
from
fff7a62
to
163a182
Compare
leonorfmartins
force-pushed
the
dualwriter/comparator
branch
from
103c243
to
84fb841
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR introduces a comparator interface which will allow to compare returned objects from both stores and assert on its equality.
This comparator can later be called on each dualwriter and its result pushed to metrics (defined here)
Why do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Relates to https://github.com/grafana/search-and-storage-team/issues/37
Special notes for your reviewer:
Please check that: