Getting Started with Declarative Gradle and Subsite #63
Conversation
oleg-nenashev
requested review from
adammurdoch,
eskatos,
pioterj,
big-guy and
lkasso
|
|
||
| Scope: Declarative Gradle can be evaluated with limited functionality and with support from the team. | ||
| This includes: | ||
| the alpha release of the Declarative Gradle plugins, |
There was a problem hiding this comment.
I would not do that, unless we can reference items
| @@ -56,7 +56,8 @@ Converted subprojects: | |||
|
|
|||
| Let’s take a look at a `build.gradle.dcl` file which replaces the common `build.gradle` or `build.gradle.kts` files: | |||
|
|
|||
| core/common/build.gradle.dcl | |||
| _core/common/build.gradle.dcl_ | |||
There was a problem hiding this comment.
❗ The example below this can be updated to remove the entire buildTypes block, it no longer needs to be explicit.
There was a problem hiding this comment.
Let's do in a follow-uo
|
|
||
| ## Installing Components | ||
|
|
||
| - You will need the latest [Gradle Build Tool nightly build](https://gradle.org/nightly/). |
There was a problem hiding this comment.
🤔 I would make this disclaimer even more prominent. I try to keep the wrapper up-to-date, but sometimes miss it or it isn't immediately possible (waiting on reviews). I'd make this a callout and note that running this project frequently requires bleeding edge features and experiments only available in the nightly, and that you might have to manually download it, etc.
There was a problem hiding this comment.
Agreed, but I do not think it should be in getting started, which is a read-once thing. I would add it to the generic user guide if you're fine with that
There was a problem hiding this comment.
#65 for the follow-up
|
One more comment - the Declarative Gradle roadmap timeline goes from right -> left as time increases, whereas the main Gradle roadmap goes from left -> right. Shouldn't these use the same direction? |
Co-authored-by: Laura Kassovic <[email protected]> Co-authored-by: Tom Tresansky <[email protected]>
Subject to discuss with @pioterj who reordered the main roadmap :) |
This is a bulk change that improves the documentation:
For #42 #45 #44