Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distribution_url property to override download URL #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sgammon
Copy link

@sgammon sgammon commented Sep 13, 2023

Adds a distribution_url property to the action, which overrides the download URL unconditionally. It is up to the caller to provide an archive which works on their Github Actions runner; there is no way (at this time) to vary the distribution URL by architecture or OS.

  • feat: add distribution_url input option
  • feat: honor distribution_url in all branches
  • chore: update docs with distribution_url info

Fixes and closes #60.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 13, 2023
Adds a `distribution_url` property to the action, which overrides
the download URL unconditionally. It is up to the caller to
provide an archive which works on their Github Actions runner;
there is no way (at this time) to vary the distribution URL by
architecture or OS.

- feat: add `distribution_url` input option
- feat: honor `distribution_url` in all branches
- chore: update docs with `distribution_url` info

Fixes and closes graalvm#60

Signed-off-by: Sam Gammon <[email protected]>
sgammon added a commit to elide-dev/elide that referenced this pull request Sep 13, 2023
sgammon added a commit to elide-dev/elide that referenced this pull request Sep 14, 2023
sgammon added a commit to elide-dev/elide that referenced this pull request Sep 18, 2023
sgammon added a commit to elide-dev/elide that referenced this pull request Sep 19, 2023
sgammon added a commit to elide-dev/elide that referenced this pull request Sep 19, 2023
@@ -45,10 +46,10 @@ async function run(): Promise<void> {
if (isGraalVMforJDK17OrLater) {
switch (distribution) {
case c.DISTRIBUTION_GRAALVM:
graalVMHome = await graalvm.setUpGraalVMJDK(javaVersion)
graalVMHome = await graalvm.setUpGraalVMJDK(javaVersion, customDistributionUrl)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of letting customDistributionUrl creep into all these setUp functions, I'd prefer if we handle customDistributionUrl.length > 0 in one place. What do you think?

@fniephaus fniephaus self-assigned this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to use a custom distribution URL
2 participants