Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old stale args file #589

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Conversation

n0tl3ss
Copy link
Contributor

@n0tl3ss n0tl3ss commented Apr 1, 2024

Problem:
Copying args file into Docker with something similar to
COPY *.args /home/app/graalvm-native-image.args causes problem because there might be more then one generated args file. This is required because convertToArgsFile creates temporary file that contains contains random integer in the name.

Solution:

  • Maven write-args-file task should delete old stale args file before generating a new one.

Fixes micronaut-projects/micronaut-maven-plugin#1048

Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

  • PR author: n0tl3ss

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Apr 1, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Apr 1, 2024
@alvarosanchez alvarosanchez merged commit 08d4a02 into graalvm:master Apr 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Native packaging fails if there is an existing args file in the target directory
3 participants