Add support for default-for attribute
#432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new index.json attribute is design to allow more flexible version matching to avoid breakage due to switch on latest version for untested ones. It should have a `default-for` key and a regexp as a string value, for example "1\\.0\\..*" which should match versions like "1.0.0", "1.0.1", "1.0.2", etc. See oracle/graalvm-reachability-metadata#62 See oracle/graalvm-reachability-metadata#275
oracle-contributor-agreement
bot
added
the
OCA Verified
This was referenced Apr 28, 2023
fniephaus
reviewed
May 2, 2023
...lvm/reachability/internal/index/artifacts/SingleModuleJsonVersionToConfigDirectoryIndex.java
Outdated
Show resolved
Hide resolved
melix
requested changes
May 2, 2023
...lvm/reachability/internal/index/artifacts/SingleModuleJsonVersionToConfigDirectoryIndex.java
Outdated
Show resolved
Hide resolved
Perform 2 distinct findConfigurationFor invocations in order to not be dependent of the order.
|
@aclement Could you please give your +1 for merging this PR? |
|
looks good to me. |
fniephaus
reviewed
May 3, 2023
| * | ||
| * @param groupId the group ID of the artifact | ||
| * @param artifactId the artifact ID of the artifact | ||
| * @param version the version of the artifact | ||
| * @return a configuration directory, or empty if no configuration directory is available | ||
| */ | ||
| @Override | ||
| public Optional<DirectoryConfiguration> findLatestConfigurationFor(String groupId, String artifactId, String version) { |
There was a problem hiding this comment.
The name is no longer accurate. Not sure if we want to change it?
There was a problem hiding this comment.
Could you please elaborate?
There was a problem hiding this comment.
findLatestConfigurationFor, shouldn't it be something like findMatchingConfigurationFor now?
melix
approved these changes
May 3, 2023
|
Don't forget release notes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new
index.jsonattribute is design to allow more flexible version matching to avoid breakage due to switch on latest version for untested ones.It should have a
default-forkey and a regexp as a string value, for example "1\.0\..*" which should match versions like "1.0.0", "1.0.1", "1.0.2", etc.Please do not merge before @aclement has given his +1.
See oracle/graalvm-reachability-metadata#62
See oracle/graalvm-reachability-metadata#275