Set mainClass as optional, fix samples to be usable standalone #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdeleuze
reviewed
Jul 30, 2021
melix
requested changes
Jul 30, 2021
native-gradle-plugin/src/main/java/org/graalvm/buildtools/gradle/dsl/NativeImageOptions.java
Show resolved
Hide resolved
1456c69
to
7a10214
Compare
sdeleuze
requested changes
Jul 30, 2021
There was a problem hiding this comment.
Works for me with my additional comments on formatting and after clarifying with @melix the mavenLocal(), I admit I added it as well locally for my gradle publishToMavenLocal but I guess he has another workflow to recommend.
| @@ -93,7 +93,7 @@ class JavaApplicationWithAgentFunctionalTest extends AbstractFunctionalTest { | |||
| @Unroll("agent property takes precedence on Gradle #version with JUnit Platform #junitVersion") | |||
| def "agent property takes precedence"() { | |||
| gradleVersion = version | |||
|
|
|||
There was a problem hiding this comment.
If you can rollback for cleaner diff that would be great.
| @@ -50,7 +50,7 @@ class KotlinApplicationWithTestsFunctionalTest extends AbstractFunctionalTest { | |||
| @Unroll("can execute Kotlin tests in a native image directly on Gradle #version with JUnit Platform #junitVersion") | |||
| def "can execute Kotlin tests in a native image directly"() { | |||
| gradleVersion = version | |||
|
|
|||
There was a problem hiding this comment.
If you can rollback for cleaner diff that would be great.
Before this commit if mainClass was missing, Gradle plugin would abort the build. This is wrong since mainClass isn't required for building shared libraries (also, mainClass can be defined using properties file). This change fixes #108 Second change that is introduced in this commit fixes issue #105
7a10214
to
cb6fc03
Compare
melix
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit if mainClass was missing, Gradle plugin would abort the build.
This is wrong since mainClass isn't required for building shared libraries (also,
mainClass can be defined using properties file). This change fixes #108
Second change that is introduced in this commit fixes issue #105