Provide release_version for class BinarySuite #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In mx.graal-core/mx_graal_8.py _updateGraalPropertiesFile() calls release_version for the jvmci suite. In the binary suite usecase this results in: AttributeError: BinarySuite instance has no attribute 'release_version'. To make jvmci usable as binary suite release_version is provided for class BinarySuite.
|
This is actually more about making graal-core available as a binary suite. |
olpaw
added a commit
that referenced
this pull request
Mar 14, 2016
Provide release_version for class BinarySuite
dougxc
pushed a commit
that referenced
this pull request
May 17, 2016
* commit '8ed06d553c71fcbeaecc7c1f433971e73a853109': Only load mx.mx/env when it's the primary suite and pick up defaults from ~/.mx/env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In mx.graal-core/mx_graal_8.py _updateGraalPropertiesFile() calls
release_version for the jvmci suite. In the binary suite usecase this
results in: AttributeError: BinarySuite instance has no attribute
'release_version'. To make jvmci usable as binary suite release_version
is provided for class BinarySuite.
See: #71