Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-51173] Improve computation of suite root dirs. #279

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

ansalond
Copy link
Member

@ansalond ansalond commented Jan 8, 2024

To locate the root dir of a suite, mx:

  • checks if the suite is contained in one or more multiple VCS, returning the one with the deepest nesting
  • if no VCS is found, looks at .mx_vcs_root and ci.hocon files

We should try both approaches and return the "most nested" result (that is, the longest path, which we assume it's the closest to the suite).

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 8, 2024
@ansalond
Copy link
Member Author

ansalond commented Jan 8, 2024

/cc @zakkak, since these changes affect #221

Copy link
Contributor

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ansalond

@graalvmbot graalvmbot merged commit 8019078 into graalvm:master Jan 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants