Support for musl-based Linux #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
Wouldn't it be better to include |
|
They should be interchangeable on Linux (same for poll.h, signal.h etc), but I'm not sure about Windows and Darwin |
|
Looks like that should be fine for Windows and a quick check on a macOS machine shows that it has |
gilles-duboscq
approved these changes
Feb 3, 2023
|
I'll start integrating that. I'll take care of bumping the mx version number. |
|
You can now depend on the updated behaviour by requesting a minimal mx version of 6.15.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of fixes related to musl-based Linux support:
linux-musl, thenlinux, then<others>-Wno-error=cppforlinux-muslso that it doesn't complain about nonstandard headers such as<sys/errno.h>This is needed to take advantage of oracle/graal#3141