Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL rewrites with support for more digests #271

Closed
wants to merge 1 commit into from

Conversation

ceresek
Copy link

@ceresek ceresek commented Nov 7, 2022

The changes in 74fd67a left a cast in from when digest was just a string, this breaks when digest is an instance of Digest. Looks like simple removal of the cast works fine (at least it does in our local infrastructure).

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Nov 7, 2022
@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@ceresek
Copy link
Author

ceresek commented Nov 7, 2022

@dougxc I have signed the OCA under the commit mail [email protected]. Since this is a trivial update, maybe doing it on your side would be more flexible than me going through the signing process again ?

@dougxc
Copy link
Member

dougxc commented Nov 7, 2022

@dougxc I have signed the OCA under the commit mail [email protected]. Since this is a trivial update, maybe doing it on your side would be more flexible than me going through the signing process again ?

Will do. I'll slightly change the fix to just be self.digest = digest as well.

@ceresek
Copy link
Author

ceresek commented Nov 10, 2022

Thank you :-)

I'll slightly change the fix to just be self.digest = digest as well.

You compiler people are optimizing everywhere :-)

@ceresek ceresek closed this Nov 10, 2022
@ceresek ceresek deleted the fix/url-rewrite-digests branch May 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Required At least one contributor does not have an approved Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants