Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mx fetch-jdk python2 compatible #239

Closed
wants to merge 1 commit into from
Closed

Make mx fetch-jdk python2 compatible #239

wants to merge 1 commit into from

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Jun 22, 2021

Closes #238

@dougxc
Copy link
Member

dougxc commented Jun 22, 2021

Hi @zakkak , we are close to removing all python2 support from mx so this is going in the wrong direction.

@zakkak
Copy link
Contributor Author

zakkak commented Jun 22, 2021

Thanks Doug, good to know!

@zakkak zakkak closed this Jun 22, 2021
@zakkak zakkak mentioned this pull request Jun 22, 2021
Closed
@zakkak zakkak deleted the mx-fetchjdk-python2-compatibility branch June 22, 2021 20:31
@dougxc
Copy link
Member

dougxc commented Jun 23, 2021

Turns out that there's enough people still relying on fetch-jdk to work with python2 so I'll merge this fix after all.

@zakkak zakkak restored the mx-fetchjdk-python2-compatibility branch June 23, 2021 12:24
@zakkak zakkak reopened this Jun 23, 2021
@zakkak
Copy link
Contributor Author

zakkak commented Jun 24, 2021

Merged in fe5916d

@zakkak zakkak closed this Jun 24, 2021
@zakkak zakkak deleted the mx-fetchjdk-python2-compatibility branch June 24, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
oca-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mx fetch-jdk failure with python2
3 participants
@zakkak @dougxc @graalvmbot