Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue where spaces in global options defined by mx extensions caused problems. #23

Merged
merged 3 commits into from
Feb 2, 2016
Merged

Fixed issue where spaces in global options defined by mx extensions caused problems. #23

merged 3 commits into from
Feb 2, 2016

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented Feb 2, 2016

No description provided.

@dougxc
fix bug in handling of spaces in global options defined by suite exte…
7968ad2 
…nsions (e.g., --vmprefix "/usr/bin/gdb --args")
@dougxc
Copy link
Member Author

dougxc commented Feb 2, 2016

This addresses issue #20.

@dougxc dougxc mentioned this pull request Feb 2, 2016
Closed
@zapster
Copy link
Member

zapster commented Feb 2, 2016

It seems like this breaks non-mx option handling:

$ mx java -version
  File "/.../mx.py", line 12287, in <module>
    main()
  File "/.../mx.py", line 12160, in main
    _argParser._parse_cmd_line(_opts, firstParse=True)
  File "/.../mx.py", line 6460, in _parse_cmd_line
    assert ' ' in arg, arg
AssertionError: -version

zapster added a commit that referenced this pull request Feb 2, 2016
@zapster
Merge pull request #23 from dougxc/space_in_global_option
7757d5c 
Fixed issue where spaces in global options defined by mx extensions caused problems.
@zapster zapster merged commit 7757d5c into graalvm:master Feb 2, 2016
@dougxc dougxc deleted the space_in_global_option branch March 2, 2016 09:47
dougxc pushed a commit that referenced this pull request Apr 14, 2016
@gilles-duboscq
Merge pull request #23 in G/mx from ~MICK.JORDAN_ORACLE.COM/mx:featur…
d7ba8b8 
…e/rmbench to master

* commit 'fd4d484ccbdc2253f8a1eb42aaeb355a2c9da3ca':
  Remove test/bench commands
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zapster zapster

Labels
oracle-emp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dougxc @zapster @thomaswue