Group classes by function or type

[neomatrix369]

On the back of #194 I have started to slowly group together classes, methods/functions, fields/variables that come across as fulfilling similar functionality.

For this sweep I picked these 3 categories:

• Language support
• OS/Arch/Platform
• Suite

Doing this should help identify temporal coupling, preparing the file for refactoring later on.

I re-ran the graal build via https://circleci.com/gh/neomatrix369/awesome-graal/503 which builds this particular repo and branch.

Build status of this branch:

[dougxc]

Why do we need this file?

[neomatrix369]

To enable running checks done by this command, before creating a PR, its similar to what you have done in the travis-ci builds

[dougxc]

Ok but I don't think we need it in the repo. Can you please remove it.

[neomatrix369]

Done! Removed!

[dougxc]

Given the size of the diff with all this rearranging, please make sure the PR contains only rearranging so that it should be trivially equivalent to the original code. Note that there's still a risk in breakage when moving module level statements (which includes class and method definitions) but hopefully our gate with catch any problems related to that.

[neomatrix369]

Given the size of the diff with all this rearranging, please make sure the PR contains only rearranging so that it should be trivially equivalent to the original code. Note that there's still a risk in breakage when moving module level statements (which includes class and method definitions) but hopefully our gate with catch any problems related to that.

Yes I have taken care to see there is no reason for breakage - the IDE is helping, plus I'm building using the build script to run the changed version of mx each time. These changes are just moving the blocks closer to each other so they can be extracted.

There is still a chance of breakage, and this could indicate to us something when it happens either code that needs fixing, usually less optimal couplings can cause it.

[neomatrix369]

I'll rebase mx.py to fix the conflict reported by github.

[dougxc]

Please don't rebase. If I cannot resolve conflicts when integrating, I'll reach out for help. Please let me know once you're ready for me to try integrate this PR.

[neomatrix369]

Please proceed, this PR is good to go!

[neomatrix369]

@dougxc any chance of this being reviewed if you have the bandwidth?

[dougxc]

I'm trying to integrate it now.

[gilles-duboscq]

For anybody ever needing to review this kind of changes, this was reviewed using this script based on an idea from @ansalond.
This cuts the top-level declarations of a python script into files that can then easily be processed by diff.

[neomatrix369]

For anybody ever needing to review this kind of changes, this was reviewed using this script based on an idea from @ansalond.
This cuts the top-level declarations of a python script into files that can then easily be processed by diff.

Thanks for letting us know.

Let's hope we don't have to do reviews on such file for long!

[neomatrix369]

I'm trying to integrate it now.

Thanks!

[neomatrix369]

For anybody ever needing to review this kind of changes, this was reviewed using this script based on an idea from @ansalond.
This cuts the top-level declarations of a python script into files that can then easily be processed by diff.

Good work with the script - nice work! I just applied it to the PR #197

I think the cut.py script should be made part of the python repos like mx under some folder i.e. dev-tools or dev-utils so everyone can use it for reviewing large source files.

[neomatrix369]

For anybody ever needing to review this kind of changes, this was reviewed using this script based on an idea from @ansalond.
This cuts the top-level declarations of a python script into files that can then easily be processed by diff.

I have created a bash script which can be run after running your cut.py script, see https://gist.github.com/neomatrix369/a945d9766ccedceadf37b97e467eeab7

Using diff it gathers the files that are different and captures the differences which can later be posted in a diff.

[gilles-duboscq]

I think the cut.py script should be made part of the python repos like mx under some folder i.e. dev-tools or dev-utils so everyone can use it for reviewing large source files.

I think it is (and should remain!) rather rare to make changes that shuffle everything around. It is not about reviewing large source files (the standard tools do that just fine), it's about reviewing changes which just re-order a lot of things (regardless of the size of the files).