Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TestNG support. #102

Closed
wants to merge 2 commits into from
Closed

Add TestNG support. #102

wants to merge 2 commits into from

Conversation

christhalinger
Copy link
Contributor

SQE is adding some new JVMCI tests and is using TestNG. I want them to integrate the new tests with mx.

@dougxc
Copy link
Member

dougxc commented Mar 23, 2016

This is just adding the TestNG library to mx without any command for running TestNG tests. It would make more sense to add the library to the mx suite that includes TestNG based sources and (possibly) has an mx extension command for running them. Or are you planning on modifying the unittest command in mx to also support TestNG tests?

@christhalinger
Copy link
Contributor Author

Yeah, I noticed that as well after I was poking around in the new tests. unittest should support running TestNG tests. I'm looking into it right now.

dougxc pushed a commit that referenced this pull request Jun 1, 2016
* commit '408e3dfa405555225f804dbec8083554ebabfc70':
  Allow skipping of suite updates in sforceimports
@graalvmbot
Copy link
Collaborator

  • User Christian Thalinger with email address christian -(dot)- thalinger -(at)- oracle -(dot)- com has not signed Oracle OCA

@graalvmbot
Copy link
Collaborator

  • It appears that user Christian Thalinger with email address christian -(dot)- thalinger -(at)- oracle -(dot)- com has not signed the Oracle Contributor Agreement.

If you believe this is an error, please contact [email protected].

@graalvmbot
Copy link
Collaborator

  • It appears that user Chris Thalinger with email address cthalinger -(at)- twitter -(dot)- com has not signed the Oracle Contributor Agreement.

If you believe this is an error, please contact [email protected].

@graalvmbot
Copy link
Collaborator

  • User Chris Thalinger with email address cthalinger -(at)- twitter -(dot)- com is now cleared for contributions.
  • The following email(s) have not yet signed the Oracle Contributor Agreement: [email protected]

@graalvmbot
Copy link
Collaborator

  • User Christian Thalinger with email address christian -(dot)- thalinger -(at)- oracle -(dot)- com is now cleared for contributions.

@dougxc
Copy link
Member

dougxc commented Jul 22, 2016

Christian, are you still looking into modifying the unittest command or can I close this issue as won't fix?

@christhalinger
Copy link
Contributor Author

I was wondering about this myself :) At this point I don't care, so we can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants