Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added CONTRIBUTING.md #10

Merged
merged 2 commits into from
Jan 27, 2016
Merged

added CONTRIBUTING.md #10

merged 2 commits into from
Jan 27, 2016

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented Jan 26, 2016

No description provided.

@dougxc dougxc assigned thomaswue and chumer and unassigned thomaswue and chumer Jan 26, 2016
from your github profile.

Pull requests can only be merged by committers and a committer cannot merge
their own pull requests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"their" => "his"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then I'll go with "his or her"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even better :) !

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"their" is usually acceptable singular for such situations.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I did not know that. My English teacher would have surely objected ;).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while I'm aware that "their" is acceptable grammar here, I think "his or her" reads better, especially for those whose first language is English ;-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, is there (or their? ;-) ) a convention for signing off on github pull request reviews?

@smarr
Copy link
Collaborator

smarr commented Jan 27, 2016

signing off? you mean like this: www.lgtm.in 😉

thomaswue added a commit that referenced this pull request Jan 27, 2016
@thomaswue thomaswue merged commit a84b1f8 into graalvm:master Jan 27, 2016
dougxc pushed a commit that referenced this pull request Apr 6, 2016
…x:topic/fix-tee-stdout to master

* commit '620f1817ea86fba744593affc86c7d62c1fa0cee':
  Avoid double-lines in captured standard output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants